Skip to content

Conversation

@shcarr-r7
Copy link

Check List

  • Tests have been run in packages where changes have been made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Problem

forceNoCache is effectively ignored under some conditions. In cachedQueryResult(), depending on the values of queryBody.cacheMode, queryBody.renewQuery, and options.backgroundRenew it will exit early and cube will continue to use cache regardless of forceNoCache.

Description of Changes Made (if issue reference is not provided)

Prioritize forceNoCache by checking it's value earlier in cachedQueryResult() and exiting early if true.

I only added a simple test, but I'd be happy to add more.

@shcarr-r7 shcarr-r7 requested a review from a team as a code owner November 20, 2025 10:26
@github-actions github-actions bot added javascript Pull requests that update Javascript code pr:community Contribution from Cube.js community members. labels Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code pr:community Contribution from Cube.js community members.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant